Skip to content

Remove rarely used rt_time_t#10752

Merged
Rbb666 merged 1 commit intoRT-Thread:masterfrom
lygstate:rt_time_t_removal
Oct 10, 2025
Merged

Remove rarely used rt_time_t#10752
Rbb666 merged 1 commit intoRT-Thread:masterfrom
lygstate:rt_time_t_removal

Conversation

@lygstate
Copy link
Contributor

@lygstate lygstate commented Sep 27, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

Remove unused rt_time_t and use time_t treewide

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions github-actions bot added BSP: NXP Code related with NXP BSP BSP: GD32 BSP related with GD32 libcpu labels Sep 27, 2025
@github-actions
Copy link

github-actions bot commented Sep 27, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：rt_time_t_removal
  • 设置PR number为 \ Set the PR number to：10752
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 rt_time_t_removal 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the rt_time_t_removal branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@lygstate lygstate force-pushed the rt_time_t_removal branch 3 times, most recently from 758fa2a to e623e87 Compare September 27, 2025 10:40
@meng-plus
Copy link
Contributor

meng-plus commented Sep 29, 2025

提交pr建议合并为一个提交 如果涉及多个不同功能 应当分开多次提交

Rbb666
Rbb666 reviewed Oct 9, 2025
View reviewed changes
@Rbb666
Copy link
Member

Rbb666 commented Oct 9, 2025

提交pr建议合并为一个提交 如果涉及多个不同功能 应当分开多次提交

同意，麻烦作者重新修改下，如果拆分提交需要说清楚每一个commit的内容
@lygstate

@lygstate
Remove rarely used rt_time_t
775526a 
next_delay should be rt_tick_t

Use time_t for RT_DEVICE_CTRL_RTC_GET_TIME
@lygstate lygstate changed the title Remove unused rt_time_t and use time_t treewide Remove rarely used rt_time_t Oct 10, 2025
@Rbb666 Rbb666 merged commit 62bc4ba into RT-Thread:master Oct 10, 2025
55 of 56 checks passed
@lygstate lygstate deleted the rt_time_t_removal branch October 11, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

@kurisaW kurisaW Awaiting requested review from kurisaW

@supperthomas supperthomas Awaiting requested review from supperthomas

Assignees

No one assigned

Labels

BSP: GD32 BSP related with GD32 BSP: NXP Code related with NXP BSP libcpu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lygstate @meng-plus @Rbb666